Skip to main content

Reviewing a Merge request

The merge request is to be reviewed by someone other than the author of the commit. This is the place to question things before applying the changes from this working branch into the main branch. Often times, discussions will lead to more changes. If changes need to be made, the original author can make the new changes to their same local branch, push the changes, and the merge request will reset any approvals and show the new changes.

Browser​

  1. In your browser, go to merge requests
  2. From the list, select a merge request
  3. The overview tab contains the approve button along with a section you can leave comments that don't correspond to any specific line of code.
  4. Select the chagnes tab
  5. While reviewing the changes, you can add comment now or add to review
    • add comment now: immediately leaves a comment and pushes a notification
    • add to review: leaves a comment, but doesn't publish it until you click finish review at the bottom. This sends out a single notification for all the comments you leave in a review
  6. Select the Overview tab review

Local​

Sometimes you want to see the changes on your desktop, but are working on something you don't want to lose. What do you do!? There are a few things you can do, but for simplicity, we're going to clone a new repo just for reviews

  1. In your terminal, navigate to where you want to clone the repo and run:
update your username

In the URL, don't forget to change the <username> to your username!

git clone https://<username>@code.levelup.cce.af.mil/262-cos/Electric-Eagle.git review-electric-eagle
  1. Checkout the branch you want to review
git checkout <some/branch>
  1. When you're done, you can delete the review-electric-eagle directory
note

You don't have to delete it as long as you're comfortable discarding any changes you made, pulling the repo, and checking out whatever branch.